From 190ae97a528b6be0a6a0d850852aedab39f67ed4 Mon Sep 17 00:00:00 2001
From: Hammy <sgoudham@gmail.com>
Date: Fri, 31 Dec 2021 09:31:17 +0000
Subject: [PATCH] Add List_delete() & List_pop()

---
 src/list.c      | 26 +++++++++++++++++++++
 src/test/test.c | 62 +++++++++++++++++++++++++++++++++++++++++--------
 2 files changed, 78 insertions(+), 10 deletions(-)

diff --git a/src/list.c b/src/list.c
index 9d5407c..f7ba7fc 100644
--- a/src/list.c
+++ b/src/list.c
@@ -106,6 +106,32 @@ int List_remove(List *list, int element) {
     return 0;
 }
 
+int List_delete(List *list, int index) {
+    if (!list) {
+        return 1;
+    }
+
+    if (index < 0 || index > list->_currentSize) {
+        return ERRNO_003;
+    }
+
+    int elementToDelete = list->_array[index];
+    for (int i = index; i < list->_currentSize; i++) {
+        list->_array[i] = list->_array[i + 1];
+    }
+    list->_currentSize--;
+
+    return elementToDelete;
+}
+
+int List_pop(List *list) {
+    if (!list) {
+        return 1;
+    }
+
+    return List_delete(list, list->_currentSize);
+}
+
 int List_sort(List *list, bool reverse) {
     return List_mergeSort(list, 0, list->_currentSize, reverse);
 }
diff --git a/src/test/test.c b/src/test/test.c
index 214ce3b..5898af2 100644
--- a/src/test/test.c
+++ b/src/test/test.c
@@ -18,8 +18,8 @@ void shouldReturnListLengthZero() {
 
     // Act -> Assert
     assert(List_length(list) == 0);
-    List_destroy(&list);
 
+    List_destroy(&list);
     printSuccess(__func__);
 }
 
@@ -31,8 +31,8 @@ void shouldReturnListLengthTwo() {
 
     // Act -> Assert
     assert(List_length(list) == 2);
-    List_destroy(&list);
 
+    List_destroy(&list);
     printSuccess(__func__);
 }
 
@@ -49,8 +49,8 @@ void shouldReturnSortedListInAscendingOrder() {
     for (int i = 0; i < List_length(list); i++) {
         assert(List_get(list, i) == i);
     }
-    List_destroy(&list);
 
+    List_destroy(&list);
     printSuccess(__func__);
 }
 
@@ -67,8 +67,8 @@ void shouldClearList() {
 
     // Assert
     assert(List_length(list) == 0);
-    List_destroy(&list);
 
+    List_destroy(&list);
     printSuccess(__func__);
 }
 
@@ -85,8 +85,8 @@ void shouldReturnListMaxLengthTwenty() {
 
     // Assert
     assert(List_max_length(list) == 20);
-    List_destroy(&list);
 
+    List_destroy(&list);
     printSuccess(__func__);
 }
 
@@ -104,9 +104,9 @@ void shouldCopyPopulatedList() {
     for (int i = 0; i < List_length(copiedList); i++) {
         assert(List_get(list, i) == List_get(copiedList, i));
     }
+
     List_destroy(&list);
     List_destroy(&copiedList);
-
     printSuccess(__func__);
 }
 
@@ -120,8 +120,8 @@ void shouldInsertElementIntoListIndexZero() {
 
     // Assert
     assert(List_get(list, 0) == 0);
-    List_destroy(&list);
 
+    List_destroy(&list);
     printSuccess(__func__);
 }
 
@@ -135,9 +135,9 @@ void shouldCopyEmptyList() {
     // Assert
     assert(List_length(copiedList) == 0);
     assert(List_max_length(copiedList) == 10);
+
     List_destroy(&list);
     List_destroy(&copiedList);
-
     printSuccess(__func__);
 }
 
@@ -154,8 +154,8 @@ void shouldRemoveElementFromList() {
     assert(List_get(list, 0) == 1);
     assert(List_get(list, 1) == 2);
     assert(List_get(list, 2) == 0);
-    List_destroy(&list);
 
+    List_destroy(&list);
     printSuccess(__func__);
 }
 
@@ -174,8 +174,8 @@ void shouldReverseList() {
     assert(List_get(list, 2) == 75);
     assert(List_get(list, 3) == 100);
     assert(List_get(list, 4) == 50);
-    List_destroy(&list);
 
+    List_destroy(&list);
     printSuccess(__func__);
 }
 
@@ -195,9 +195,49 @@ void shouldExtendList() {
     for (int i = 0; i < 5; i++) {
         assert(List_get(list_to_extend, i) == i + 1);
     }
+
     List_destroy(&list_to_extend);
     List_destroy(&input_list);
+    printSuccess(__func__);
+}
 
+void shouldDeleteElementFromList() {
+    // Arrange
+    List *list = List_new();
+    List_append_all(list, 6, 0, 1, 2, 3, 4, 5);
+
+    // Act
+    int deletedElement = List_delete(list, 1);
+
+    // Assert
+    assert(deletedElement == 1);
+    assert(List_length(list) == 5);
+    assert(List_get(list, 0) == 0);
+    assert(List_get(list, 1) == 2);
+    assert(List_get(list, 2) == 3);
+    assert(List_get(list, 3) == 4);
+    assert(List_get(list, 4) == 5);
+
+    List_destroy(&list);
+    printSuccess(__func__);
+}
+
+void shouldPopElementFromList() {
+    // Arrange
+    List *list = List_new();
+    List_append_all(list, 6, 0, 1, 2, 3, 4, 5);
+
+    // Act
+    int poppedElement = List_pop(list);
+
+    // Assert
+    assert(poppedElement == 5);
+    assert(List_length(list) == 5);
+    for (int i = 0; i < 5; i++) {
+        assert(List_get(list, i) == i);
+    }
+
+    List_destroy(&list);
     printSuccess(__func__);
 }
 
@@ -216,6 +256,8 @@ int main() {
     shouldRemoveElementFromList();
     shouldReverseList();
     shouldExtendList();
+    shouldDeleteElementFromList();
+    shouldPopElementFromList();
     printf("\n\n============================================");
     printf("\nFINISH TESTING");
     printf("\n============================================");