From 58822a8565e4decfc3434daa04e7d0e4b260f7d0 Mon Sep 17 00:00:00 2001 From: Hammy Date: Fri, 31 Dec 2021 00:22:15 +0000 Subject: [PATCH] Revert "Return deleted element from List_remove()" --- src/list.c | 3 +-- src/list.h | 2 +- src/test/test.c | 3 +-- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/list.c b/src/list.c index 36f9eba..9d5407c 100644 --- a/src/list.c +++ b/src/list.c @@ -98,13 +98,12 @@ int List_remove(List *list, int element) { return ERRNO_005; } - int elementToDelete = list->_array[positionToDelete]; for (int i = positionToDelete; i < list->_currentSize; i++) { list->_array[i] = list->_array[i + 1]; } list->_currentSize--; - return elementToDelete; + return 0; } int List_sort(List *list, bool reverse) { diff --git a/src/list.h b/src/list.h index 1d7bfff..3886e25 100644 --- a/src/list.h +++ b/src/list.h @@ -107,7 +107,7 @@ int List_insert(List *list, int index, int element); * * Returns * ---------------------------- - * int (The deleted element) + * int (0 for success, Non-0 for error) */ int List_remove(List *list, int element); diff --git a/src/test/test.c b/src/test/test.c index 60bb1d9..214ce3b 100644 --- a/src/test/test.c +++ b/src/test/test.c @@ -147,10 +147,9 @@ void shouldRemoveElementFromList() { List_append_all(list, 4, 0, 1, 2, 0); // Act - int deletedElement = List_remove(list, 0); + List_remove(list, 0); // Assert - assert(deletedElement == 0); assert(List_length(list) == 3); assert(List_get(list, 0) == 1); assert(List_get(list, 1) == 2);