From 71879a78d3a23249a2e967e7ce042acb8ef24b98 Mon Sep 17 00:00:00 2001 From: briandennis Date: Mon, 12 Mar 2018 14:24:11 -0700 Subject: [PATCH] encode nbsp in svg for safari --- README.md | 8 ++++---- pages/editor.js | 4 ++++ 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index e25fc20..a32eec4 100644 --- a/README.md +++ b/README.md @@ -80,9 +80,9 @@ Thanks goes out to all these wonderful people ([emoji key](https://github.com/ke -| [
briandennis](https://github.com/briandennis)
[πŸ’»](/dawnlabs/carbon/commits?author=briandennis "Code") [πŸ“–](/dawnlabs/carbon/commits?author=briandennis "Documentation") [πŸš‡](#infra-briandennis "Infrastructure (Hosting, Build-Tools, etc)") [πŸ‘€](#review-briandennis "Reviewed Pull Requests") | [
mfix22](https://github.com/mfix22)
[πŸ’¬](#question-mfix22 "Answering Questions") [πŸ’»](/dawnlabs/carbon/commits?author=mfix22 "Code") [πŸ€”](#ideas-mfix22 "Ideas, Planning, & Feedback") | [
jakedex](https://github.com/jakedex)
[πŸ’¬](#question-jakedex "Answering Questions") [πŸ’»](/dawnlabs/carbon/commits?author=jakedex "Code") [🎨](#design-jakedex "Design") [πŸ“Ή](#video-jakedex "Videos") | [
andrewda](https://github.com/andrewda)
[πŸ’¬](#question-andrewda "Answering Questions") [πŸ’»](/dawnlabs/carbon/commits?author=andrewda "Code") [πŸ›](/dawnlabs/carbon/issues?q=author%3Aandrewda "Bug reports") [πŸ‘€](#review-andrewda "Reviewed Pull Requests") | [
yeskunall](https://github.com/yeskunall)
[πŸ’»](/dawnlabs/carbon/commits?author=yeskunall "Code") [πŸ“–](/dawnlabs/carbon/commits?author=yeskunall "Documentation") [πŸ”§](#tool-yeskunall "Tools") [πŸ›](/dawnlabs/carbon/issues?q=author%3Ayeskunall "Bug reports") | [
stoshfabricius](https://github.com/stoshfabricius)
[πŸ’»](/dawnlabs/carbon/commits?author=stoshfabricius "Code") | [
jkling38](https://github.com/jkling38)
[πŸ“–](/dawnlabs/carbon/commits?author=jkling38 "Documentation") | +| [
briandennis](https://github.com/briandennis)
[πŸ’»](https://github.com/dawnlabs/carbon/commits?author=briandennis "Code") [πŸ“–](https://github.com/dawnlabs/carbon/commits?author=briandennis "Documentation") [πŸš‡](#infra-briandennis "Infrastructure (Hosting, Build-Tools, etc)") [πŸ‘€](#review-briandennis "Reviewed Pull Requests") | [
mfix22](https://github.com/mfix22)
[πŸ’¬](#question-mfix22 "Answering Questions") [πŸ’»](https://github.com/dawnlabs/carbon/commits?author=mfix22 "Code") [πŸ€”](#ideas-mfix22 "Ideas, Planning, & Feedback") | [
jakedex](https://github.com/jakedex)
[πŸ’¬](#question-jakedex "Answering Questions") [πŸ’»](https://github.com/dawnlabs/carbon/commits?author=jakedex "Code") [🎨](#design-jakedex "Design") [πŸ“Ή](#video-jakedex "Videos") | [
andrewda](https://github.com/andrewda)
[πŸ’¬](#question-andrewda "Answering Questions") [πŸ’»](https://github.com/dawnlabs/carbon/commits?author=andrewda "Code") [πŸ›](https://github.com/dawnlabs/carbon/issues?q=author%3Aandrewda "Bug reports") [πŸ‘€](#review-andrewda "Reviewed Pull Requests") | [
yeskunall](https://github.com/yeskunall)
[πŸ’»](https://github.com/dawnlabs/carbon/commits?author=yeskunall "Code") [πŸ“–](https://github.com/dawnlabs/carbon/commits?author=yeskunall "Documentation") [πŸ”§](#tool-yeskunall "Tools") [πŸ›](https://github.com/dawnlabs/carbon/issues?q=author%3Ayeskunall "Bug reports") | [
stoshfabricius](https://github.com/stoshfabricius)
[πŸ’»](https://github.com/dawnlabs/carbon/commits?author=stoshfabricius "Code") | [
jkling38](https://github.com/jkling38)
[πŸ“–](https://github.com/dawnlabs/carbon/commits?author=jkling38 "Documentation") | | :---: | :---: | :---: | :---: | :---: | :---: | :---: | -| [
otobrglez](https://github.com/otobrglez)
[πŸ’»](/dawnlabs/carbon/commits?author=otobrglez "Code") | [
darahak](https://github.com/darahak)
[πŸ“–](/dawnlabs/carbon/commits?author=darahak "Documentation") | [
dom96](https://github.com/dom96)
[πŸ’»](/dawnlabs/carbon/commits?author=dom96 "Code") | [
elrumordelaluz](https://github.com/elrumordelaluz)
[πŸ’»](/dawnlabs/carbon/commits?author=elrumordelaluz "Code") | [
cjb](https://github.com/cjb)
[πŸ’»](/dawnlabs/carbon/commits?author=cjb "Code") | [
Krzysztof-Cieslak](https://github.com/Krzysztof-Cieslak)
[πŸ’»](/dawnlabs/carbon/commits?author=Krzysztof-Cieslak "Code") | [
fernahh](https://github.com/fernahh)
[πŸ“–](/dawnlabs/carbon/commits?author=fernahh "Documentation") | -| [
g3r4n](https://github.com/g3r4n)
[πŸ’»](/dawnlabs/carbon/commits?author=g3r4n "Code") | [
Mat Gadd](http://drarok.com/)
[πŸ›](/dawnlabs/carbon/issues?q=author%3ADrarok "Bug reports") [πŸ’»](/dawnlabs/carbon/commits?author=Drarok "Code") | [
Brad Davies](https://bradlab.co.uk)
[πŸ›](/dawnlabs/carbon/issues?q=author%3Avarbrad "Bug reports") [πŸ’»](/dawnlabs/carbon/commits?author=varbrad "Code") | [
Rafael CΓ’mara](http://www.rafaelcamaram.com/)
[πŸ’»](/dawnlabs/carbon/commits?author=rafaelcamaram "Code") | [
Gleb Bahmutov](https://glebbahmutov.com/)
[⚠️](/dawnlabs/carbon/commits?author=bahmutov "Tests") [πŸ”§](#tool-bahmutov "Tools") | [
IvΓ‘n MunguΓ­a](https://ivan-munguia.netlify.com)
[πŸ’»](/dawnlabs/carbon/commits?author=warborn "Code") | [
Dillon Mulroy](https://dillonmulroy.com)
[πŸ’»](/dawnlabs/carbon/commits?author=dmmulroy "Code") | -| [
Nihad Abbasov](https://github.com/NARKOZ)
[πŸ’»](/dawnlabs/carbon/commits?author=NARKOZ "Code") | [
Hugo Torzuoli](https://torzuolih.github.io)
[πŸ“–](/dawnlabs/carbon/commits?author=TorzuoliH "Documentation") | [
Bruno C. Couto](https://github.com/bruno02221)
[πŸ’»](/dawnlabs/carbon/commits?author=bruno02221 "Code") | [
Mark Molnar](https://github.com/molnarmark)
[πŸ’»](/dawnlabs/carbon/commits?author=molnarmark "Code") | [
Takahiko Inayama](https://www.behance.net/tetra2000)
[πŸ’»](/dawnlabs/carbon/commits?author=TETRA2000 "Code") | [
François Martin](https://github.com/martinfrancois)
[πŸ’»](/dawnlabs/carbon/commits?author=martinfrancois "Code") | +| [
otobrglez](https://github.com/otobrglez)
[πŸ’»](https://github.com/dawnlabs/carbon/commits?author=otobrglez "Code") | [
darahak](https://github.com/darahak)
[πŸ“–](https://github.com/dawnlabs/carbon/commits?author=darahak "Documentation") | [
dom96](https://github.com/dom96)
[πŸ’»](https://github.com/dawnlabs/carbon/commits?author=dom96 "Code") | [
elrumordelaluz](https://github.com/elrumordelaluz)
[πŸ’»](https://github.com/dawnlabs/carbon/commits?author=elrumordelaluz "Code") | [
cjb](https://github.com/cjb)
[πŸ’»](https://github.com/dawnlabs/carbon/commits?author=cjb "Code") | [
Krzysztof-Cieslak](https://github.com/Krzysztof-Cieslak)
[πŸ’»](https://github.com/dawnlabs/carbon/commits?author=Krzysztof-Cieslak "Code") | [
fernahh](https://github.com/fernahh)
[πŸ“–](https://github.com/dawnlabs/carbon/commits?author=fernahh "Documentation") | +| [
g3r4n](https://github.com/g3r4n)
[πŸ’»](https://github.com/dawnlabs/carbon/commits?author=g3r4n "Code") | [
Mat Gadd](http://drarok.com/)
[πŸ›](https://github.com/dawnlabs/carbon/issues?q=author%3ADrarok "Bug reports") [πŸ’»](https://github.com/dawnlabs/carbon/commits?author=Drarok "Code") | [
Brad Davies](https://bradlab.co.uk)
[πŸ›](https://github.com/dawnlabs/carbon/issues?q=author%3Avarbrad "Bug reports") [πŸ’»](https://github.com/dawnlabs/carbon/commits?author=varbrad "Code") | [
Rafael CΓ’mara](http://www.rafaelcamaram.com/)
[πŸ’»](https://github.com/dawnlabs/carbon/commits?author=rafaelcamaram "Code") | [
Gleb Bahmutov](https://glebbahmutov.com/)
[⚠️](https://github.com/dawnlabs/carbon/commits?author=bahmutov "Tests") [πŸ”§](#tool-bahmutov "Tools") | [
IvΓ‘n MunguΓ­a](https://ivan-munguia.netlify.com)
[πŸ’»](https://github.com/dawnlabs/carbon/commits?author=warborn "Code") | [
Dillon Mulroy](https://dillonmulroy.com)
[πŸ’»](https://github.com/dawnlabs/carbon/commits?author=dmmulroy "Code") | +| [
Nihad Abbasov](https://github.com/NARKOZ)
[πŸ’»](https://github.com/dawnlabs/carbon/commits?author=NARKOZ "Code") | [
Hugo Torzuoli](https://torzuolih.github.io)
[πŸ“–](https://github.com/dawnlabs/carbon/commits?author=TorzuoliH "Documentation") | [
Bruno C. Couto](https://github.com/bruno02221)
[πŸ’»](https://github.com/dawnlabs/carbon/commits?author=bruno02221 "Code") | [
Mark Molnar](https://github.com/molnarmark)
[πŸ’»](https://github.com/dawnlabs/carbon/commits?author=molnarmark "Code") | [
Takahiko Inayama](https://www.behance.net/tetra2000)
[πŸ’»](https://github.com/dawnlabs/carbon/commits?author=TETRA2000 "Code") | [
François Martin](https://github.com/martinfrancois)
[πŸ’»](https://github.com/dawnlabs/carbon/commits?author=martinfrancois "Code") | diff --git a/pages/editor.js b/pages/editor.js index eb9314f..81b2d2d 100644 --- a/pages/editor.js +++ b/pages/editor.js @@ -147,6 +147,10 @@ class Editor extends React.Component { save({ format } = { format: 'png' }) { this.getCarbonImage({ format }).then(dataUrl => { + if (format === 'svg') { + dataUrl = dataUrl.split(' ').join(' ') + } + const link = document.createElement('a') link.download = `carbon.${format}` link.href = dataUrl