From 9dc13f702e83493945163ef0694823cb4cfe5335 Mon Sep 17 00:00:00 2001
From: Mike Fix <mrfix84@gmail.com>
Date: Thu, 8 Aug 2019 17:04:49 -0700
Subject: [PATCH] clean up SelectionEditor code

---
 components/SelectionEditor.js | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/components/SelectionEditor.js b/components/SelectionEditor.js
index 34ef896..51a8a72 100644
--- a/components/SelectionEditor.js
+++ b/components/SelectionEditor.js
@@ -12,7 +12,7 @@ function ModifierButton(props) {
       center
       margin="0 8px 0 0"
       style={{ borderBottom: `1px solid ${props.selected ? 'white' : 'transparent'}` }}
-      onClick={() => props.onChange(s => !s)}
+      onClick={props.onClick}
     >
       {props.children}
     </Button>
@@ -21,10 +21,13 @@ function ModifierButton(props) {
 
 function SelectionEditor({ position, onChange }) {
   const [open, setOpen] = React.useState(false)
+
   const [bold, setBold] = React.useState(false)
   const [italics, setItalics] = React.useState(false)
   const [underline, setUnderline] = React.useState(false)
+
   const [color, setColor] = React.useState(null)
+
   React.useEffect(() => {
     onChange({
       bold,
@@ -33,6 +36,7 @@ function SelectionEditor({ position, onChange }) {
       color
     })
   }, [onChange, bold, color, italics, underline])
+
   return (
     <Popout
       hidden={false}
@@ -45,13 +49,13 @@ function SelectionEditor({ position, onChange }) {
     >
       <div className="colorizer">
         <div className="modifier">
-          <ModifierButton selected={bold} onChange={setBold}>
+          <ModifierButton selected={bold} onClick={() => setBold(v => !v)}>
             <b>B</b>
           </ModifierButton>
-          <ModifierButton selected={italics} onChange={setItalics}>
+          <ModifierButton selected={italics} onClick={() => setItalics(v => !v)}>
             <i>I</i>
           </ModifierButton>
-          <ModifierButton selected={underline} onChange={setUnderline}>
+          <ModifierButton selected={underline} onClick={() => setUnderline(v => !v)}>
             <u>U</u>
           </ModifierButton>
           <button className="color-square" onClick={() => setOpen(o => !o)} />