From 442ce80d50aee04bdc93ed3097e8d6437cbc57c7 Mon Sep 17 00:00:00 2001
From: sgoudham <sgoudham@gmail.com>
Date: Sun, 15 Jan 2023 07:02:25 +0000
Subject: [PATCH] refactor: tidy up

---
 .github/workflows/build.yml  | 16 +++++++---------
 .github/workflows/deploy.yml |  6 ++++++
 pom.xml                      |  3 +--
 3 files changed, 14 insertions(+), 11 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 15a0ac7..71473d4 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -33,14 +33,6 @@ jobs:
       - name: Test
         run: mvn test
 
-      - name: Upload Coverage to Codecov
-        uses: codecov/codecov-action@v3
-        with:
-          token: ${{ secrets.CODECOV_TOKEN }}
-          directory: ./target/site/jacoco
-          files: jacoco.xml
-          fail_ci_if_error: false
-
       - name: Retrieve Name & Version
         run: |
           echo "VERSION=$(mvn help:evaluate -Dexpression=project.version -q -DforceStdout)" >> $GITHUB_ENV
@@ -62,4 +54,10 @@ jobs:
         uses: actions/upload-artifact@v3
         with:
           name: ${{ env.NAME }}-${{ env.VERSION }}-sources.jar
-          path: ./target/${{ env.NAME }}-${{ env.VERSION }}-sources.jar
\ No newline at end of file
+          path: ./target/${{ env.NAME }}-${{ env.VERSION }}-sources.jar
+
+      - name: Archive Shaded Jar
+        uses: actions/upload-artifact@v3
+        with:
+          name: ${{ env.NAME }}-${{ env.VERSION }}-shaded.jar
+          path: ./target/${{ env.NAME }}-${{ env.VERSION }}-shaded.jar
\ No newline at end of file
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
index f4b3498..087b245 100644
--- a/.github/workflows/deploy.yml
+++ b/.github/workflows/deploy.yml
@@ -57,6 +57,12 @@ jobs:
           name: ${{ env.NAME }}-${{ env.VERSION }}-sources.jar
           path: ./target/${{ env.NAME }}-${{ env.VERSION }}-sources.jar
 
+      - name: Archive Shaded Jar
+        uses: actions/upload-artifact@v3
+        with:
+          name: ${{ env.NAME }}-${{ env.VERSION }}-shaded.jar
+          path: ./target/${{ env.NAME }}-${{ env.VERSION }}-shaded.jar
+
       - name: Create Release
         uses: ncipollo/release-action@v1
         with:
diff --git a/pom.xml b/pom.xml
index 0040406..c87b5ac 100644
--- a/pom.xml
+++ b/pom.xml
@@ -144,9 +144,8 @@
                             <goal>shade</goal>
                         </goals>
                         <configuration>
-<!--                            <outputFile>${project}-${version}-shaded</outputFile>-->
                             <shadedArtifactAttached>true</shadedArtifactAttached>
-                            <shadedClassifierName>shaded</shadedClassifierName> <!-- Any name that makes sense -->
+                            <shadedClassifierName>shaded</shadedClassifierName>
                         </configuration>
                     </execution>
                 </executions>