remove routing TODO

5 years ago · 0d26638d1d
parent f7998ef250
commit 0d26638d1d
3 changed files with 4 additions and 4 deletions
--- a/lib/routing.js
+++ b/lib/routing.js
@ -128,8 +128,8 @@ export const getRouteState = router => {
      .split('/')
      .pop()
  )
-  // TODO fix this hack
-  const parameter = path.length >= 19 && path.indexOf('.') === -1 && path
+
+  const parameter = path.length >= 19 && path.indexOf('.') < 0 ? path : null

  return {
    parameter,
--- a/pages/[id].js
+++ b/pages/[id].js
@ -10,7 +10,7 @@ class IdPage extends React.PureComponent {
  static contextType = ApiContext
  static async getInitialProps({ req, res, query }) {
    const path = query.id
-    const parameter = path && path.length >= 19 && path.indexOf('.') < 0 && path
+    const parameter = path.length >= 19 && path.indexOf('.') < 0 ? path : null

    let snippet
    if (parameter) {
--- a/pages/embed/[id].js
+++ b/pages/embed/[id].js
@ -10,7 +10,7 @@ class EmbedIdPage extends React.PureComponent {
  static contextType = ApiContext
  static async getInitialProps({ req, res, query }) {
    const path = query.id
-    const parameter = path && path.length >= 19 && path.indexOf('.') < 0 && path
+    const parameter = path.length >= 19 && path.indexOf('.') < 0 ? path : null

    let snippet
    if (parameter) {