macos-click-through
Kian-Meng Ang 2 years ago committed by GitHub
parent a628e6fe1b
commit 73ddc335b2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -39,10 +39,10 @@ jobs:
# Pay attention not to break BUILD stage of a test, # Pay attention not to break BUILD stage of a test,
# when tests are failing at BUILD stage, everything after -- is ignored, # when tests are failing at BUILD stage, everything after -- is ignored,
# and no json output will be generated. # and no json output will be generated.
# Becouse those arguments is passed to compiled test binary. And it is failed to compile. # Because those arguments is passed to compiled test binary. And it is failed to compile.
cargo test -- -Z unstable-options --format json > results.json cargo test -- -Z unstable-options --format json > results.json
# This and `set -eo pipefail` for MacOS/Linux # This and `set -eo pipefail` for MacOS/Linux
# is added, becouse without it pipe will eat exit status. # is added, because without it pipe will eat exit status.
# Docs are stating that it should work by default, but it does not. # Docs are stating that it should work by default, but it does not.
# https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#exit-codes-and-error-action-preference # https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#exit-codes-and-error-action-preference
# Oh, it still does not fail on Windows. ¯\_(ツ)_/¯ # Oh, it still does not fail on Windows. ¯\_(ツ)_/¯

@ -75,7 +75,7 @@ fn main() {
// The editor is responsible for processing and transforming redraw events into something // The editor is responsible for processing and transforming redraw events into something
// more readily renderable. Ligature support and multi window management requires some // more readily renderable. Ligature support and multi window management requires some
// significant preprocessing of the redraw events in order to capture what exactly should get // significant preprocessing of the redraw events in order to capture what exactly should get
// drawn where. Futher this step takes a bit of processing power to accomplish, so it is done // drawn where. Further this step takes a bit of processing power to accomplish, so it is done
// on it's own thread. Ideally heavily computationally expensive tasks should be done in the // on it's own thread. Ideally heavily computationally expensive tasks should be done in the
// editor. // editor.
// //

@ -70,7 +70,7 @@ impl KeyboardManager {
event: WindowEvent::ModifiersChanged(modifiers), event: WindowEvent::ModifiersChanged(modifiers),
.. ..
} => { } => {
// Record the modifer states so that we can properly add them to the keybinding // Record the modifier states so that we can properly add them to the keybinding
// text // text
self.shift = modifiers.shift_key(); self.shift = modifiers.shift_key();
self.ctrl = modifiers.control_key(); self.ctrl = modifiers.control_key();

Loading…
Cancel
Save